Differential D25281

[GTK3] Improve legibility of Firefox CSD colours
AbandonedPublic
Actions

Authored by cblack on Nov 12 2019, 10:27 PM.

Details

Reviewers
None
Group Reviewers
VDG
Breeze
Summary

This fixes the CSD colors of Firefox to be more legible, but not without caveats due to upstream issues.

  • The inactive titlebar foreground color is used regardless of window state.
  • #MozillaGtkWidget does not have any visible way to discriminate between CSD on and CSD off unlike normal GTK windows, so any style changes apply to both.

BUG: 407639

Test Plan

SSD:



CSD:

Diff Detail

Repository
R98 Breeze for Gtk
Branch
firefox-csd-fix (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18731
Build 18749: arc lint + arc unit
cblack created this revision.Nov 12 2019, 10:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 12 2019, 10:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Nov 12 2019, 10:27 PM
cblack edited the summary of this revision. (Show Details)Nov 12 2019, 10:30 PM
cblack edited the test plan for this revision. (Show Details)
ngraham added a subscriber: ngraham.Nov 12 2019, 10:33 PM

This suffers from the same problem as the earlier version in that the SSD versions of the apps look like this:

This is a problem with the current state of the Breeze color scheme because of heavy the titlebar color looks when applied to the rest of the tools area underneath it. However Once we implement the Breeze color scheme changes to support T10201, these apps will in fact automatically look like how we want!

So I won't formally object, but I think we should delay landing the changes until T10201 is done for other apps.

broulik added a subscriber: broulik.Nov 13 2019, 10:04 AM
However Once we implement the Breeze color scheme changes

How is that related? If i keep using a dark title bar I will still have that issue. Merely changing the colorscheme doesn't fix the underlying bug?

ngraham added a comment.Nov 13 2019, 2:41 PM
In D25281#561861, @broulik wrote:
However Once we implement the Breeze color scheme changes

How is that related? If i keep using a dark title bar I will still have that issue. Merely changing the colorscheme doesn't fix the underlying bug?

No, but it makes it less severe with the default color scheme. In fact, it makes Firefox the Thunderbird look quite good imo. :)

cblack abandoned this revision.Apr 1 2020, 7:55 PM

Revision Contents
Changeset List

PathPackages
Msrc/gtk3/applications/_firefox.scss (12 lines)

Diff 69656

View Options

src/gtk3/applications/_firefox.scss

Loading...