Differential D25252

Fix binding loop in lockscreen media controls
ClosedPublic
Actions

Authored by davidedmundson on Nov 11 2019, 10:06 AM.

Details

Reviewers
broulik
ngraham
Group Reviewers
Plasma
Commits
R120:419b9708ee9e: Fix binding loop in lockscreen media controls
Summary

When we load and position the Image the height is constrained, the width
is not. The image fillMode is set as PreserveAspectFit so the width
will adjust to fit the aspect ratio,

Therefore we only want to set a fixed height on the sourceSize, it will
automatically match the resultant width.

BUG: 413087
FIXED-IN: 5.17.3

Test Plan

I was unable to reproduce the state.
Patch is based on reading the code and docs

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18691
Build 18709: arc lint + arc unit
Restricted Application added a project: Plasma. · View Herald TranscriptNov 11 2019, 10:06 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 11 2019, 10:06 AM
filipf added a subscriber: filipf.Nov 11 2019, 2:53 PM

I'm not seeing any binding loop warnings when testing this fwiw.

broulik accepted this revision.Nov 11 2019, 2:58 PM
broulik added a subscriber: broulik.

Clever!

This revision is now accepted and ready to land.Nov 11 2019, 2:58 PM
ngraham accepted this revision.Nov 11 2019, 3:11 PM
ngraham edited the summary of this revision. (Show Details)
Closed by commit R120:419b9708ee9e: Fix binding loop in lockscreen media controls (authored by davidedmundson). · Explain WhyNov 11 2019, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69575

View Options

lookandfeel/contents/lockscreen/MediaControls.qml

Loading...