Fix binding loop in lockscreen media controls
ClosedPublic

Authored by davidedmundson on Mon, Nov 11, 10:06 AM.

Details

Summary

When we load and position the Image the height is constrained, the width
is not. The image fillMode is set as PreserveAspectFit so the width
will adjust to fit the aspect ratio,

Therefore we only want to set a fixed height on the sourceSize, it will
automatically match the resultant width.

BUG: 413087
FIXED-IN: 5.17.3

Test Plan

I was unable to reproduce the state.
Patch is based on reading the code and docs

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Nov 11, 10:06 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mon, Nov 11, 10:06 AM
filipf added a subscriber: filipf.Mon, Nov 11, 2:53 PM

I'm not seeing any binding loop warnings when testing this fwiw.

broulik accepted this revision.Mon, Nov 11, 2:58 PM
broulik added a subscriber: broulik.

Clever!

This revision is now accepted and ready to land.Mon, Nov 11, 2:58 PM
ngraham accepted this revision.Mon, Nov 11, 3:11 PM
ngraham edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.