Recent version of KPeople (5.62) added editable contacts. KPeopleVCard no longer compiles because of missing header definitions.
Details
- Reviewers
apol - Commits
- R732:32d50a944003: Bump version of KPeople
Before:
Compile - Compile with <5.62 -> Build fails -> Be sad
After:
Compile with <5.62 -> CMake tells you to get a newer version
Compile with >=5.62 -> Build succeeds -> Be happy
Diff Detail
- Repository
- R732 KPeople VCard Support
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Change version to 5.62 since that is the version bump after Aleix's changes to add editable contacts
Is it really necessary to split KF5 dependencies in two parts here? I don't see this being done anywhere else, KF5_MIN_VERSION is always global. Likewise, the Qt5 line change is simply unnecessary.
You tell me. It's very useful in my case because my distro has only KFrameworks v5.61 so I have to bend over to even install KPeople v5.62 but if you don't like having separate dependency lines that's easy enough to change back.
It's not necessary, but it results in "REQUIRED" "COMPONENTS" and the first library name lining up across all three lines.
Okay, makes sense to me
CMakeLists.txt | ||
---|---|---|
20–22 | I don't understand why you added a new space there. |
What do you want me to do? Your message does not line up with your code comment.
CMakeLists.txt | ||
---|---|---|
20–22 | It's not necessary, but it results in "REQUIRED" "COMPONENTS" and the first library name lining up across all three lines. |