[KPropertiesDialog] provide a way of showing the target of a symlink
Needs ReviewPublic

Authored by ngraham on Sat, Nov 9, 2:55 AM.

Details

Reviewers
None
Group Reviewers
VDG
Frameworks
Summary

BUG: 413002
FIXED-IN: 5.65

Undecided on the button. Should it be text-only displaying "Show" instead of an icon?
Or text-and-icon? Is there a better icon we could use or is this one good enough?

Test Plan

Diff Detail

Repository
R241 KIO
Branch
show-link-target-in-properties-dialog (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18753
Build 18771: arc lint + arc unit
ngraham created this revision.Sat, Nov 9, 2:55 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSat, Nov 9, 2:55 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Sat, Nov 9, 2:55 AM

Or maybe should the UI be changed to show a clickable link and an "edit" button that temporarily turns it into a text field that lets you edit it?

ndavis added a subscriber: ndavis.Mon, Nov 11, 1:09 AM
ndavis added inline comments.
src/widgets/kpropertiesdialog.cpp
1120

go-jump is more semantically correct.

ndavis added a comment.EditedMon, Nov 11, 1:20 AM

Or maybe should the UI be changed to show a clickable link and an "edit" button that temporarily turns it into a text field that lets you edit it?

So like this?

​/media/external-drive/Pictures

That might be a good idea. I don't think anyone would want to accidentally edit it and click OK.

Actually I played with that and in retrospect I don't think it would work. If we give it a "link-like" appearance, that would suggest that clicking on it would actually open the destination file/folder (i.e. the typical link behavior), which is not what we want here. We want to show it in the file manager, not open it. I'll stay with the current approach and change the icon as @ndavis requested.

ngraham updated this revision to Diff 69684.Wed, Nov 13, 4:29 PM
ngraham marked an inline comment as done.

Use more semantically correct icon

Last question: give the button text, or stick with the icon only? I ask because go-jump is kind of an odd icon IMO: