i18n: Add msgctxt attributes to split strings "Contacts"
ClosedPublic
Actions

Authored by aspotashev on Nov 8 2019, 1:38 AM.

Details

Reviewers

schwarzer
bshah
nicolasfella

Commits

R156:d638035c22de: i18n: Add msgctxt attributes to split strings "Contacts"

Test Plan

Run trunk/l10n-kf5/scripts/extract-messages.sh , check contents of .pot file.

Diff Detail

Repository

R156 KAccounts Providers

Branch

xml-i18n-split

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18583
Build 18601: arc lint + arc unit

aspotashev requested review of this revision.Nov 8 2019, 1:38 AM

aspotashev created this revision.

Harbormaster completed remote builds in B18583: Diff 69419.Nov 8 2019, 1:38 AM

aspotashev added a reviewer: schwarzer.Nov 8 2019, 1:39 AM

Bhushan, Nico, you're the last ones to touch something in this repo, does this seem reasoable?

I don't know enough about the service stuff to comment on technicalities, but all of these services are in the disabled/ folder, so it doesn't really matter. If you want it in nontheless go for it.

bshah accepted this revision.Nov 10 2019, 2:44 PM

This revision is now accepted and ready to land.Nov 10 2019, 2:44 PM

Closed by commit R156:d638035c22de: i18n: Add msgctxt attributes to split strings "Contacts" (authored by aspotashev). · Explain WhyNov 10 2019, 3:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			Messages.sh (2 lines)
M			services/disabled/facebook-contacts.service.in (2 lines)
M			services/disabled/google-contacts.service.in (2 lines)
M			services/disabled/owncloud-contacts.service.in (2 lines)
M			services/disabled/runners-contacts.service.in (2 lines)