Add "authenticate" action
ClosedPublic
Actions

Authored by kmaterka on Nov 5 2019, 10:27 AM.

Details

Reviewers

ndavis
dantti
ngraham
broulik

Maniphest Tasks

T11977: [Print Manager] Add "authenticate" action and notification

Commits

R363:56144c185b07: Add "authenticate" action

Summary

When printer/job requires authentication, for example SMB share, it is not possible to authenticate the job.
This change adds "Authenticate" menu action.

Part of the T11977

Test Plan

Add printer that requires authentincation, for example SMB share.
Do not provide username nor password.
Job will be held with status authentication error.
Right click on the job, select "Authenticate" menu action.

CCBUG: 313619

Diff Detail

Repository

R363 Print Manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18516
Build 18534: arc lint + arc unit

kmaterka created this revision.Nov 5 2019, 10:27 AM

Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptNov 5 2019, 10:27 AM

kmaterka requested review of this revision.Nov 5 2019, 10:27 AM

Harbormaster completed remote builds in B18516: Diff 69306.Nov 5 2019, 10:27 AM

kmaterka edited the summary of this revision. (Show Details)Nov 5 2019, 10:31 AM

kmaterka added reviewers: ndavis, dantti, ngraham, broulik.

Lgtm thanks

This revision is now accepted and ready to land.Nov 5 2019, 11:08 AM

kmaterka added a task: T11977: [Print Manager] Add "authenticate" action and notification.Nov 5 2019, 11:54 AM

Minor typo

Harbormaster completed remote builds in B18519: Diff 69315.Nov 5 2019, 12:09 PM

Closed by commit R363:56144c185b07: Add "authenticate" action (authored by kmaterka). · Explain WhyNov 5 2019, 12:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libkcups/JobModel.h (3 lines)
M			libkcups/JobModel.cpp (4 lines)
M			libkcups/KCupsConnection.h (5 lines)
M			libkcups/KCupsJob.h (3 lines)
M			libkcups/KCupsJob.cpp (15 lines)
M			libkcups/KCupsPrinter.h (1 line)
M			libkcups/KCupsPrinter.cpp (5 lines)
M			libkcups/KCupsRequest.h (2 lines)
M			libkcups/KCupsRequest.cpp (10 lines)
M			printqueue/PrintQueueUi.h (1 line)
M			printqueue/PrintQueueUi.cpp (176 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69306	0c850eb		Nov 5 2019, 10:27 AM	★	★
Diff 2	69315	0c850eb	Minor typo	Nov 5 2019, 12:09 PM	★	★
Diff 3	69316	0c850eb	R363:56144c185b0758e2e2a63330eb144797bd20e579	Nov 5 2019, 12:04 PM	★	★