Last steps to normalize some compressed file types and to deduplicate code in krarc.cpp and krarchandler.cpp.
ClosedPublic

Authored by asensi on Aug 20 2016, 4:30 PM.

Details

Summary

Last part of the operation aimed to

  • Normalize the file types of several compressed file types
  • Remove duplicate code in krarc.cpp and krarchandler.cpp.

After the present changes: there isn't any compressed file type with a '/' as a first character. For more information anyone can see the proposed modifications and also:

Test Plan

Several operations (opening, extracting, and (when possible) deleting and adding) were performed with the new source code, using 28 different compressed files. Those operations left a trace (in /tmp/krdebug), that trace was the same (excluding some trivial changes like the numbers of the lines of the source code) than the trace obtained using the previous source code and the same operations.

Diff Detail

Repository
R167 Krusader
Lint
Lint Skipped
Unit
Unit Tests Skipped
asensi updated this revision to Diff 6092.Aug 20 2016, 4:30 PM
asensi retitled this revision from to Last steps to normalize some compressed file types and to deduplicate code in krarc.cpp and krarchandler.cpp..
asensi updated this object.
asensi edited the test plan for this revision. (Show Details)
asensi added a reviewer: Krusader.
asensi set the repository for this revision to R167 Krusader.
asensi added a project: Krusader.
asensi added a subscriber: Krusader.
martinkostolny accepted this revision.Aug 20 2016, 6:49 PM
martinkostolny added a reviewer: martinkostolny.
martinkostolny added a subscriber: martinkostolny.

It works with browsing and writing performed on my set of archives. Thanks, Toni!

This revision is now accepted and ready to land.Aug 20 2016, 6:49 PM
gengisdave accepted this revision.Aug 21 2016, 9:58 AM
gengisdave added a reviewer: gengisdave.
asensi closed this revision.Aug 22 2016, 7:55 PM