Disable the restore defaults button if the KCModule says so
ClosedPublic
Actions

Authored by ervin on Oct 30 2019, 11:07 AM.

Details

Reviewers

mart
davidedmundson

Group Reviewers

Plasma

Commits

Summary

Also realigns the button state management with the one from
KCMultiDialog (used in kcmshell).

Repository

R124 System Settings

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ervin requested review of this revision.Oct 30 2019, 11:07 AM

core/ModuleView.cpp
427	Not saying this is wrong, but can you explain this change? In https://phabricator.kde.org/D25072 we do setEnabled((buttons & Default) && !defaulted) rather than changing visibility, presumably it's there to make sure buttons don't move as you navigate between modules.

Deal with David's comment and realign ModuleView with KCMultiDialog regarding button state management.

core/ModuleView.cpp
427	It feels kind of wrong indeed. Better align that behavior with the one from kcmshell. I'll make a reworked patch in that direction.

This revision is now accepted and ready to land.Nov 4 2019, 2:34 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			core/ModuleView.h (1 line)
M			core/ModuleView.cpp (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69044	1f929dd		Oct 30 2019, 11:07 AM	★	★
Diff 2	69275	0e7da30	Deal with David's comment and realign ModuleView with KCMultiDialog regarding…	Nov 4 2019, 2:25 PM	★	★
Diff 3	69277	0e7da30	R124:fe180972acbb006e3362a2b487f4c47c2c6959f9	Nov 4 2019, 2:26 PM	★	★