Disable the restore defaults button if the KCModule says so
ClosedPublic

Authored by ervin on Oct 30 2019, 11:07 AM.

Details

Summary

Also realigns the button state management with the one from
KCMultiDialog (used in kcmshell).

Diff Detail

Repository
R124 System Settings
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 18356
Build 18374: arc lint + arc unit
ervin created this revision.Oct 30 2019, 11:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 30 2019, 11:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ervin requested review of this revision.Oct 30 2019, 11:07 AM
davidedmundson added inline comments.Nov 4 2019, 1:59 PM
core/ModuleView.cpp
427

Not saying this is wrong, but can you explain this change?

In https://phabricator.kde.org/D25072

we do setEnabled((buttons & Default) && !defaulted) rather than changing visibility, presumably it's there to make sure buttons don't move as you navigate between modules.

ervin updated this revision to Diff 69275.Nov 4 2019, 2:25 PM

Deal with David's comment and realign ModuleView with KCMultiDialog regarding button state management.

ervin edited the summary of this revision. (Show Details)Nov 4 2019, 2:25 PM
ervin added inline comments.Nov 4 2019, 2:29 PM
core/ModuleView.cpp
427

It feels kind of wrong indeed. Better align that behavior with the one from kcmshell. I'll make a reworked patch in that direction.

davidedmundson accepted this revision.Nov 4 2019, 2:34 PM
This revision is now accepted and ready to land.Nov 4 2019, 2:34 PM
This revision was automatically updated to reflect the committed changes.