Also realigns the button state management with the one from
KCMultiDialog (used in kcmshell).
Details
Details
- Reviewers
mart davidedmundson - Group Reviewers
Plasma - Commits
- R124:fe180972acbb: Disable the restore defaults button if the KCModule says so
Diff Detail
Diff Detail
- Repository
- R124 System Settings
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 18356 Build 18374: arc lint + arc unit
core/ModuleView.cpp | ||
---|---|---|
427 | Not saying this is wrong, but can you explain this change? In https://phabricator.kde.org/D25072 we do setEnabled((buttons & Default) && !defaulted) rather than changing visibility, presumably it's there to make sure buttons don't move as you navigate between modules. |
Comment Actions
Deal with David's comment and realign ModuleView with KCMultiDialog regarding button state management.
core/ModuleView.cpp | ||
---|---|---|
427 | It feels kind of wrong indeed. Better align that behavior with the one from kcmshell. I'll make a reworked patch in that direction. |