This ensures that the header is the correct width, and further that
the text does not disappear when there is no space for the text (so
that it elides as intended).
BUG:413433
BUG:413440
ngraham |
KNewStuff | |
Frameworks | |
Plasma |
This ensures that the header is the correct width, and further that
the text does not disappear when there is no space for the text (so
that it elides as intended).
BUG:413433
BUG:413440
Without patch: Resize a dialog to make the text not fit, and it disappears
With patch: Resize dialog, text is elided as one would expect, and the header row takes up the correct amount of space
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
src/qtquick/qml/EntryDetails.qml | ||
---|---|---|
94 | It does not. I am also unsure whether anchors.fill will work, since the titleDelegate is instantiated by a loader and its sizing behaviour is somewhat fuzzy. The only option that is guaranteed to work is setting a proper implicitWidth for the delegate. I actually spent some time trying to get balanced auto sizing behaviour working for titles when doing the ActionToolBar work, but in the end gave up because things get really tricky when you have two items that resize based on the size of the other item. |
Based on @ahiemstra's comments on the sizing logic, this seems to work...
src/qtquick/qml/EntryDetails.qml | ||
---|---|---|
94 | That is terribly annoying... So, with a bit of knowledge about this specific pair of pages, i've switched this to using implicitWidths set to the width of the page itself, so... let's see if that works a bit better. (which, incidentally, it does here, at least... but so did the previous approach...) |
Now that's fixed on the main page but it's missing margins on the right side:
And it's still broken on details pages:
Right, progress... uncomfortably, it /has/ been fine here, but after pulling recent changes in from Kirigami i can now at least reproduce your issues... which is fun. After a touch of looking around, it turns out that D24634 is what broke this. So that's fun. @ahiemstra do you have any insights here, perhaps, which would save me hunting around /too/ aimlessly? :)
Thanks to @ahiemstra for helping out with the Kirigami side :)
With that Kirigami patch, this *almost* works. There's still an empty area on the right:
The other patch updated and whatnot, and it now looks like so:
In other words, as it should! :) (and with much simplified code as well, which is always a bonus ;) )
src/qtquick/qml/EntryDetails.qml | ||
---|---|---|
93–94 | Hmm, with the new toolbar code, there's actually little reason to use a custom delegate here, since the toolbar header already uses a title + tool buttons style. You could convert the three toolbuttons to actions and drop the rest of the delegate. |
src/qtquick/qml/EntryDetails.qml | ||
---|---|---|
93–94 | Ooh... you know, that's a very good idea :) It'd be even better if we could work out how to do that with the bits on the front page as well... this /is/ intended to work for convergence and whatnot - but let's poke at that after we've got this bit sorted and such :) |