Currently the avatar in the logout screen is noticeably smaller than the avatar in the lock and logout screens.
This patch roughly bases the size value on what is produced in the lock and logout, and then applies it to the logout screen.
ngraham |
Plasma | |
VDG |
Currently the avatar in the logout screen is noticeably smaller than the avatar in the lock and logout screens.
This patch roughly bases the size value on what is produced in the lock and logout, and then applies it to the logout screen.
Before (logout screen):
After (logout screen):
Before (lock screen):
After (lock screen):
No Linters Available |
No Unit Test Coverage |
Buildable 18284 | |
Build 18302: arc lint + arc unit |
@davidedmundson I believe you wrote the code for the the avatar size in the lock and login screens (property real faceSize: Math.min(width, height - usernameDelegate.height - units.smallSpacing).
Is it alright to replace it with units.gridUnit * 7?
I tested with several screen resolutions and I can't find any issues, but new code is simpler than old code so I wonder if there's something I'm missing.
@ngraham I can change this patch so only the logout avatar' size is increased and then land that on the 5.17 as there is no risk of breaking anything. I can then change the lock screen as well, but for 5.18. They won't be precisely the same size in 5.17 though.