Currently the avatar in the logout screen is noticeably smaller than the avatar in the lock and logout screens.
This patch roughly bases the size value on what is produced in the lock and logout, and then applies it to the logout screen.
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Maniphest Tasks
- T11093: Improve Consistency across the Board
- Commits
- R120:f56e800c9634: Use the same avatar size in lock, login and logout screens
Before (logout screen):
After (logout screen):
Before (lock screen):
After (lock screen):
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
@davidedmundson I believe you wrote the code for the the avatar size in the lock and login screens (property real faceSize: Math.min(width, height - usernameDelegate.height - units.smallSpacing).
Is it alright to replace it with units.gridUnit * 7?
I tested with several screen resolutions and I can't find any issues, but new code is simpler than old code so I wonder if there's something I'm missing.
Comment Actions
@ngraham I can change this patch so only the logout avatar' size is increased and then land that on the 5.17 as there is no risk of breaking anything. I can then change the lock screen as well, but for 5.18. They won't be precisely the same size in 5.17 though.