Use the same avatar size in lock, login and logout screens
ClosedPublic

Authored by filipf on Mon, Oct 28, 10:17 PM.

Details

Summary

Currently the avatar in the logout screen is noticeably smaller than the avatar in the lock and logout screens.

This patch roughly bases the size value on what is produced in the lock and logout, and then applies it to the logout screen.

Test Plan

Before (logout screen):

After (logout screen):

Before (lock screen):

After (lock screen):

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Mon, Oct 28, 10:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Oct 28, 10:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mon, Oct 28, 10:17 PM
filipf edited the test plan for this revision. (Show Details)Mon, Oct 28, 10:19 PM
filipf added reviewers: Plasma, VDG.
ngraham accepted this revision.Mon, Oct 28, 10:26 PM
ngraham added a subscriber: ngraham.

5.17 branch

This revision is now accepted and ready to land.Mon, Oct 28, 10:26 PM

@davidedmundson I believe you wrote the code for the the avatar size in the lock and login screens (property real faceSize: Math.min(width, height - usernameDelegate.height - units.smallSpacing).

Is it alright to replace it with units.gridUnit * 7?

I tested with several screen resolutions and I can't find any issues, but new code is simpler than old code so I wonder if there's something I'm missing.

filipf added a comment.Fri, Nov 8, 5:02 PM

friendly ping

@ngraham I can change this patch so only the logout avatar' size is increased and then land that on the 5.17 as there is no risk of breaking anything. I can then change the lock screen as well, but for 5.18. They won't be precisely the same size in 5.17 though.

Probably okay to make this master-only IMO.

This revision was automatically updated to reflect the committed changes.