Differential D24995

Fix terminal not always gaining focus when shown
AbandonedPublic
Actions

Authored by alexmi on Oct 28 2019, 4:58 AM.

Details

Reviewers
tcanabrava
Group Reviewers
Dolphin
Summary

BUG: 411181
FIXED-IN: 19.12.0

Test Plan
  • Open and close the terminal panel several times, the terminal should

always gain focus when shown and not just the first time the panel is
opened.

Diff Detail

Repository
R318 Dolphin
Branch
bugfix-terminal-focus
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18243
Build 18261: arc lint + arc unit
alexmi created this revision.Oct 28 2019, 4:58 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 28 2019, 4:58 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
alexmi requested review of this revision.Oct 28 2019, 4:58 AM
broulik added a subscriber: broulik.Oct 28 2019, 7:37 AM

Doesn't terminal widget need to set the konsole part as focus proxy? This looks like a workaround

anthonyfieroni added a reviewer: tcanabrava.Oct 28 2019, 7:41 AM
anthonyfieroni added subscribers: tcanabrava, anthonyfieroni.

@tcanabrava https://phabricator.kde.org/R319:6e8153a78e3c63e514a6ecb62f6c9b4b504e7eb7 _viewSplitter->setFocusProxy(controller->view()) is missing so that's the problem to me, not related to Dolphin code.

src/panels/terminal/terminalpanel.cpp
181

It looks like konsole part widget changes its focus proxy?!

alexmi added a comment.Oct 28 2019, 9:41 AM

This diff is definitely a workaround and not the best solution, indeed it seems there was just a missing setFocusProxy() call in Konsole. I'll submit a diff there in a bit.

alexmi abandoned this revision.Oct 28 2019, 9:55 AM

New diff: D25001

Revision Contents
Changeset List

Diff 68864

View Options

src/panels/terminal/terminalpanel.cpp

Loading...