Differential D25001

Add missing setFocusProxy() call in ViewManager
ClosedPublic
Actions

Authored by alexmi on Oct 28 2019, 9:52 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:bbdf27cc9fee: Add missing setFocusProxy() call in ViewManager
Summary

This should fix the terminal not gaining focus when using konsolepart.

BUG: 411181
FIXED-IN: 19.12.0

Test Plan
  • The terminal panels in Dolphin and Kate now always gain focus

properly, not just the first time you open them

Diff Detail

Repository
R319 Konsole
Branch
bugfix-focusproxy (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18250
Build 18268: arc lint + arc unit
alexmi created this revision.Oct 28 2019, 9:52 AM
Restricted Application added a project: Konsole. · View Herald TranscriptOct 28 2019, 9:52 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
alexmi requested review of this revision.Oct 28 2019, 9:52 AM
hindenburg added a subscriber: hindenburg.Oct 28 2019, 1:45 PM

Thanks, I'll test shortly

hindenburg accepted this revision.Nov 2 2019, 3:17 PM
This revision is now accepted and ready to land.Nov 2 2019, 3:17 PM
hindenburg closed this revision.Nov 2 2019, 3:17 PM

Revision Contents
Changeset List

PathPackages
Msrc/ViewManager.cpp (1 line)

Diff 68875

View Options

src/ViewManager.cpp

Loading...