Change some 32px action icons to color style
AbandonedPublic

Authored by ndavis on Oct 27 2019, 12:51 AM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Maniphest Tasks
T10165: Large category icons should all be colorful
Summary
  • document-open-recent, document-save-all, document-save-as, document-save, folder-open-recent, view-presentation, view-preview

BUG: 412404
BUG: 412407

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Branch
color32 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18207
Build 18225: arc lint + arc unit
ndavis created this revision.Oct 27 2019, 12:51 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 27 2019, 12:51 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Oct 27 2019, 12:51 AM
ndavis edited the summary of this revision. (Show Details)Oct 27 2019, 12:56 AM
ndavis edited the test plan for this revision. (Show Details)
ndavis edited the summary of this revision. (Show Details)Oct 27 2019, 1:26 AM
mglb added a subscriber: mglb.Oct 27 2019, 12:17 PM

Why do you replace action icons instead of adding separate colorful icons for use in preference dialogs? Right now all action icons are "monochrome", making few of them colorful will introduce inconsistency.

ndavis added a subscriber: ngraham.EditedOct 27 2019, 5:03 PM
In D24975#554721, @mglb wrote:

Why do you replace action icons instead of adding separate colorful icons for use in preference dialogs? Right now all action icons are "monochrome", making few of them colorful will introduce inconsistency.

Maybe I should have explained it in the summary. It's currently kind of impossible to have consistent icon styles at 32px in 3rd party apps and we'll be breaking compatibility with 3rd party icon themes whenever we add another preferences- icon. @ngraham and I have talked about this and we decided that it might be best to just make all 32px and larger icons use the color style. In order to fix the problem we have without changing breeze-icons, we may need a new freedesktop.org icon spec that is designed to handle the type of theme we have. The current fd.o spec works in a way that assumes an icon theme will have one style. GNOME gets around that by just naming some icons symbolic, but that means apps have to choose to use symbolic icons. If you want more time to discuss changes like these and find other solutions, that's fine with me. This patch doesn't need to be landed in a hurry.

I don't have time to do all 32px icons at once, but thankfully, they're usually only used in the desktop shell (I can put 32px monochrome icons in the desktop theme), or in preferences or navigation sidebars. I suppose it also affects people who raise the toolbar icon size to 32px, but I wonder how many people even know they can do that. I could just keep this diff unlanded for as long as it takes to convert all 32px icons.

ngraham accepted this revision.Oct 27 2019, 8:23 PM

These look great to me.

This revision is now accepted and ready to land.Oct 27 2019, 8:23 PM

I don't have time to do all 32px icons at once, but thankfully, they're usually only used in the desktop shell (I can put 32px monochrome icons in the desktop theme), or in preferences or navigation sidebars. I suppose it also affects people who raise the toolbar icon size to 32px, but I wonder how many people even know they can do that. I could just keep this diff unlanded for as long as it takes to convert all 32px icons.

That might be a good idea. We'll surely get bug reports about half-color/half-monochrome icons in apps that use 32px action icons for their own category switcher sidebars, like Okular:

ndavis abandoned this revision.May 19 2020, 7:53 PM

Saving this for later on invent.