Differential D24858

Add X-KDE-Wayland-Interfaces to kwalletd desktop file
AbandonedPublic
Actions

Authored by meven on Oct 22 2019, 10:30 AM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Summary

To Prevent logs such as :
kwin_core: Did not grant the interface "org_kde_plasma_window_management" to "/usr/bin/kwalletd5" . Please request it under X-KDE-Wayland-Interfaces
kwin_core: Did not grant the interface "org_kde_kwin_keystate" to "/usr/bin/kwalletd5" . Please request it under X-KDE-Wayland-Interfaces
kwin_core: Did not grant the interface "org_kde_kwin_fake_input" to "/usr/bin/kwalletd5" . Please request it under X-KDE-Wayland-Interfaces

Diff Detail

Repository
R311 KWallet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18028
Build 18046: arc lint + arc unit
meven created this revision.Oct 22 2019, 10:30 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 22 2019, 10:30 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Oct 22 2019, 10:30 AM
apol added a comment.Oct 22 2019, 11:26 AM

These are not necessary for kwallet as far as I know. To fix this warning we'd have to look into where applications are requesting these and have these interfaces only requested when they're necessary.

meven abandoned this revision.Oct 22 2019, 2:50 PM
In D24858#552090, @apol wrote:

These are not necessary for kwallet as far as I know. To fix this warning we'd have to look into where applications are requesting these and have these interfaces only requested when they're necessary.

How can we prevent those warnings then ?

davidedmundson added a subscriber: davidedmundson.Oct 22 2019, 3:25 PM

The check comes from when the application requests a list of all available extensions, not when they actually request a specific one.
The warning is a bit premature.

kwallet most definitely shouldn't be getting the fake input extension!

meven added a comment.Oct 22 2019, 3:40 PM
In D24858#552279, @davidedmundson wrote:

The check comes from when the application requests a list of all available extensions, not when they actually request a specific one.
The warning is a bit premature.

kwallet most definitely shouldn't be getting the fake input extension!

I guessed so because kate would have needed it as well...
Thanks for the clarification @apol @davidedmundson another small thing to add to the Wayland TODO list ...

Revision Contents
Changeset List

Diff 68525

View Options

src/runtime/kwalletd/kwalletd5.desktop

Loading...