GIT_SILENT Run uncrustify-kf5 on the whole tree

Authored by ahmadsamir on Oct 15 2019, 3:35 PM.



The code still builds.

Diff Detail

R374 KolourPaint
uncrustify (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 17722
Build 17740: arc lint + arc unit
ahmadsamir requested review of this revision.Oct 15 2019, 3:35 PM
ahmadsamir created this revision.
ognarb added a subscriber: ognarb.Oct 15 2019, 3:44 PM

Instead of using uncrustify-kf5, shouldn't we use the clang-format file from T11214?

T11214 is still being discussed, and we can always run clang-format later on.

And uncrustify-kf5 has been used before on some of the KDE repos, so it's sort of have been fine-tuned a bit to KDE.

Anyway, I don't mind either way. :)

mkoller requested changes to this revision.Oct 15 2019, 7:11 PM

why ?
I don't like lots of these changes.

This revision now requires changes to proceed.Oct 15 2019, 7:11 PM

why ?
I don't like lots of these changes.

Because it doesn't follow the KDE coding style, AFAICS (and changing it to use that common style will make it easier for whoever is going to work on porting it away from kdelibs4support[1]).

Anyway, if you disagree, I'll drop this review request. :)


As an non-framework module, there is no need to follow the frameworks style, if not wanted.

ahmadsamir abandoned this revision.Oct 16 2019, 11:54 AM