Instead of using uncrustify-kf5, shouldn't we use the clang-format file from T11214?

T11214 is still being discussed, and we can always run clang-format later on.

And uncrustify-kf5 has been used before on some of the KDE repos, so it's sort of have been fine-tuned a bit to KDE.

Anyway, I don't mind either way. :)

In D24672#547744, @mkoller wrote:

why ?
I don't like lots of these changes.

Because it doesn't follow the KDE coding style, AFAICS (and changing it to use that common style will make it easier for whoever is going to work on porting it away from kdelibs4support[1]).

Anyway, if you disagree, I'll drop this review request. :)

[1]https://phabricator.kde.org/T11576

As an non-framework module, there is no need to follow the frameworks style, if not wanted.