Differential D24628

Fix incorrect margins in 16/22px media icons
ClosedPublic
Actions

Authored by ndavis on Oct 14 2019, 10:36 AM.

Details

Reviewers

ngraham

Group Reviewers

VDG

Commits

R266:83c8768b2a70: Fix incorrect margins in 16/22px media icons

Summary

For some reason, the margins on these icons were 1 px larger on each side than they were supposed to be.

Also delete media-mout and make media-record look like it does at other icon sizes. I think media-mout is a spelling error and someone forgot to fix it instead of also adding media-mount.

Test Plan

Old

New

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ndavis created this revision.Oct 14 2019, 10:36 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptOct 14 2019, 10:36 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ndavis requested review of this revision.Oct 14 2019, 10:36 AM

Harbormaster completed remote builds in B17673: Diff 67887.Oct 14 2019, 10:36 AM

ndavis added a dependent revision: D24627: [icons/media.svg] Add 16 & 32px icons, update style.Oct 14 2019, 10:36 AM

ndavis edited the summary of this revision. (Show Details)Oct 14 2019, 10:44 AM

ndavis edited the test plan for this revision. (Show Details)

ngraham accepted this revision.Oct 14 2019, 2:59 PM

This revision is now accepted and ready to land.Oct 14 2019, 2:59 PM

Closed by commit R266:83c8768b2a70: Fix incorrect margins in 16/22px media icons (authored by ndavis). · Explain WhyOct 14 2019, 7:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		icons-dark/actions/16/media-eject.svg (15 lines)
M		icons-dark/actions/16/media-mount.svg (17 lines)
M		icons-dark/actions/16/media-playback-pause.svg (15 lines)
M		icons-dark/actions/16/media-playback-start.svg (15 lines)
M		icons-dark/actions/16/media-playback-stop.svg (15 lines)
M		icons-dark/actions/16/media-record.svg (11 lines)
M		icons-dark/actions/16/media-seek-backward.svg (6 lines)
M		icons-dark/actions/16/media-seek-forward.svg (6 lines)
M		icons-dark/actions/16/media-skip-backward.svg (2 lines)
M		icons-dark/actions/16/media-skip-forward.svg (6 lines)
M		icons-dark/actions/22/media-eject.svg (17 lines)
M		icons-dark/actions/22/media-mount.svg (22 lines)
D	M	icons-dark/actions/22/media-mout.svg (14 lines)
M		icons-dark/actions/22/media-playback-pause.svg (16 lines)
M		icons-dark/actions/22/media-playback-start.svg (16 lines)
M		icons-dark/actions/22/media-playback-stop.svg (16 lines)
M		icons-dark/actions/22/media-record.svg (18 lines)
M		icons-dark/actions/22/media-seek-backward.svg (9 lines)
M		icons-dark/actions/22/media-seek-forward.svg (9 lines)
M		icons-dark/actions/22/media-skip-backward.svg (10 lines)
M		icons-dark/actions/22/media-skip-forward.svg (10 lines)
M		icons/actions/16/media-eject.svg (15 lines)
M		icons/actions/16/media-mount.svg (17 lines)
M		icons/actions/16/media-playback-pause.svg (15 lines)
M		icons/actions/16/media-playback-start.svg (15 lines)
M		icons/actions/16/media-playback-stop.svg (15 lines)
M		icons/actions/16/media-record.svg (11 lines)
M		icons/actions/16/media-seek-backward.svg (6 lines)
M		icons/actions/16/media-seek-forward.svg (6 lines)
M		icons/actions/16/media-skip-backward.svg (2 lines)
M		icons/actions/16/media-skip-forward.svg (6 lines)
M		icons/actions/22/media-eject.svg (17 lines)
M		icons/actions/22/media-mount.svg (22 lines)
D	M	icons/actions/22/media-mout.svg (14 lines)
M		icons/actions/22/media-playback-pause.svg (16 lines)
M		icons/actions/22/media-playback-start.svg (16 lines)
M		icons/actions/22/media-playback-stop.svg (16 lines)
M		icons/actions/22/media-record.svg (18 lines)
M		icons/actions/22/media-seek-backward.svg (9 lines)
M		icons/actions/22/media-seek-forward.svg (9 lines)
M		icons/actions/22/media-skip-backward.svg (10 lines)
M		icons/actions/22/media-skip-forward.svg (10 lines)