Use the text rather than highlight color for rating/star emblem

Authored by ngraham on Oct 13 2019, 4:06 PM.

Description

Use the text rather than highlight color for rating/star emblem

Summary:
The problem with using the highlight color is that the emblem becomes invisible when
applied to a UI element that's selectable and (correctly) uses the default selection
color. Making it use the text color instead fixes the bug in all cases.

Test Plan:
Stars in various UIs (Discover, Dolphin) are now black rather than blue, and the icon
can now be used on buttons without becoming invisible.

Reviewers: ndavis, VDG

Reviewed By: ndavis, VDG

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D24612

Details

Committed
ngrahamOct 14 2019, 5:08 PM
Reviewer
VDG
Differential Revision
D24612: Use the text rather than highlight color for rating/star emblem
Parents
R266:b55f299b1733: Add draw-arrow icons
Branches
Unknown
Tags
Unknown