Differential D24612

Use the text rather than highlight color for rating/star emblem
ClosedPublic
Actions

Authored by ngraham on Oct 13 2019, 4:10 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Commits
R266:a62fbad35018: Use the text rather than highlight color for rating/star emblem
Summary

The problem with using the highlight color is that the emblem becomes invisible when
applied to a UI element that's selectable and (correctly) uses the default selection
color. Making it use the text color instead fixes the bug in all cases.

Test Plan

Stars in various UIs (Discover, Dolphin) are now black rather than blue, and the icon
can now be used on buttons without becoming invisible.

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 13 2019, 4:10 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 13 2019, 4:10 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 13 2019, 4:10 PM
ndavis accepted this revision.Oct 14 2019, 6:35 AM

This icon never needed to be blue. I think I just kept it blue because that's what it was originally.

This revision is now accepted and ready to land.Oct 14 2019, 6:35 AM
Closed by commit R266:a62fbad35018: Use the text rather than highlight color for rating/star emblem (authored by ngraham). · Explain WhyOct 14 2019, 5:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 67916

View Options

icons/emblems/16/rating.svg

Loading...
View Options

icons/emblems/22/rating.svg

Loading...
View Options

icons/emblems/8/rating.svg

Loading...