Add a label and use a grabby hand cursor when hovering over a screen when there are
more than one.
BUG: 412303
FIXED-IN: 5.18.0
romangg |
Plasma | |
VDG |
Add a label and use a grabby hand cursor when hovering over a screen when there are
more than one.
BUG: 412303
FIXED-IN: 5.18.0
No Linters Available |
No Unit Test Coverage |
Buildable 17421 | |
Build 17439: arc lint + arc unit |
kcm/package/contents/ui/Output.qml | ||
---|---|---|
272 ↗ | (On Diff #67462) | Hm, can you still make the hand "close" when you press the button, which is what is typically done for dragging things |
273 ↗ | (On Diff #67462) | That won't update when outputs are added/removed, an invokable cannot be signalled |
kcm/package/contents/ui/Screen.qml | ||
59 ↗ | (On Diff #67462) | i18n |
kcm/package/contents/ui/Output.qml | ||
---|---|---|
273 ↗ | (On Diff #67462) | This is against the laws of Physics. |
kcm/package/contents/ui/Output.qml | ||
---|---|---|
273 ↗ | (On Diff #67462) |
It would, but: connect (m_config.get(), &ConfigHandler::outputModelChanged, this, &KCMKScreen::outputModelChanged); which gets emitted in ConfigHandler::setConfig(KScreen::ConfigPtr config) A new screen would be a new config. I think output model is the same object, but it would retrigger this evaluation. |
What about using a SizeAllCursor, like the screen edge button in the Plasma panel edit mode? The hand is usually used for scrolling.
kcm/package/contents/ui/Output.qml | ||
---|---|---|
273 ↗ | (On Diff #67462) | This still needs fixing. Regardless of whether it happens to work now or not. |
kcm/package/contents/ui/Screen.qml | ||
56 ↗ | (On Diff #67462) | It's better to set the left + right anchors and then setting the text alignment to be horizontally centered. That way we will wrap or elide if the translated string is too long rather than overflow. |
kcm/package/contents/ui/Output.qml | ||
---|---|---|
273 ↗ | (On Diff #67462) | Per discussion, we can do it this way for now since other pieces of code that are already committed do the same thing, and then we'll fix it for all of them in a follow-up patch. |
I'm not 100% happy with the font of the message in the overview. Maybe decrease opacity? But it's also not a pressing issue.