[kcms/colors] Generate colored GTK2 assets based off of user's colorscheme

Authored by cblack on Oct 2 2019, 9:16 PM.


Group Reviewers

The colors KCM will now call on a modified version of Breeze GTK's assets
generation script when a colorscheme is applied. This will result in a colored version
of Breeze GTK2 being generated in the user's home directory.

BUG: 412331

Test Plan

Check that a coloured version of Breeze GTK2 is generated
whenever a colourscheme is applied.

Diff Detail

R119 Plasma Desktop
colors-kcm-recolor-gtk2 (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 22451
Build 22469: arc lint + arc unit
cblack created this revision.Oct 2 2019, 9:16 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 2 2019, 9:16 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Oct 2 2019, 9:16 PM
cblack edited the summary of this revision. (Show Details)Oct 2 2019, 9:31 PM
mart accepted this revision.Oct 16 2019, 9:54 AM
This revision is now accepted and ready to land.Oct 16 2019, 9:54 AM
cblack updated this revision to Diff 75644.Feb 13 2020, 10:08 PM

Rebase on master

Can you update the text plan with detailed instructions for how to make this work? It is not working for me, and with no such text plan, I don't know why.

Can we not add more stuff to krdb, please?

davidre requested changes to this revision.Feb 17 2020, 8:50 AM
This revision now requires changes to proceed.Feb 17 2020, 8:50 AM
davidedmundson added inline comments.

Instead of this, we probably want to export the KDE_INSTALL_FULL_LIBEXECDIR to C++ and use that.

So the way forward I see as follows:
Eventually we will move stuff out of KRDB to places where it also fits in sementically. Whenever an option is changed in the kcms which call runrdb currently these things can react to that by listening to the DBus signal which is emitted currently either way now (bonus points for using KConfigWatcher).
For GTK stuff this logically would be kde-gtk-config. Since the daemon there already listens to KGlobalSettings I propose for this patch the following:

Add a new case corresponding to the color scheme change to GtkConfig::onGlobalSettingsChange inside kde-gtk-config. The lines added here can be added there as is.

cblack abandoned this revision.Apr 1 2020, 7:54 PM