Update searchbox on URL changes (Fix D24369)
ClosedPublic

Authored by iasensio on Oct 2 2019, 11:34 PM.

Details

Summary

In D24369 I introduced a regression: Where now the searchbox is updated on url changes for search urls, it is not updated anymore for regular folders. The effect is that not-indexed folders can have the extra options enabled or vice-versa. This patch fixes it, moving back the updating logic to setSearchModeEnable.

@elvisangelaccio, if you would like to revert that commit to keep the history cleaner I can rebase this one.
I'm really sorry for the inconvenience.

Test Plan
  • Searchbox updates properly when changing between search urls and regular folders, either indexed or nor-indexed.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
iasensio created this revision.Oct 2 2019, 11:34 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptOct 2 2019, 11:34 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
iasensio requested review of this revision.Oct 2 2019, 11:34 PM
elvisangelaccio accepted this revision.Oct 3 2019, 8:06 PM

@elvisangelaccio, if you would like to revert that commit to keep the history cleaner I can rebase this one.

It's ok, reverting it would actually make the history harder to follow.

This revision is now accepted and ready to land.Oct 3 2019, 8:06 PM
This revision was automatically updated to reflect the committed changes.