Differential D24308

[DataProtocol] compile without implicit coversion from ascii
ClosedPublic
Actions

Authored by ahmadsamir on Sep 30 2019, 11:59 AM.

Details

Reviewers
dfaure
Commits
R241:3b98d91436f5: [DataProtocol] compile without implicit coversion from ascii
Test Plan

make && ctest

Diff Detail

Repository
R241 KIO
Branch
ahmad/compile-without-ascii-cast (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17169
Build 17187: arc lint + arc unit
ahmadsamir created this revision.Sep 30 2019, 11:59 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 30 2019, 11:59 AM
ahmadsamir requested review of this revision.Sep 30 2019, 11:59 AM
dfaure requested changes to this revision.Oct 1 2019, 9:50 AM
dfaure added inline comments.
src/core/dataprotocol.cpp
120

It would be faster to keep a QByteArray here and just compare to ' ' and possibly \t.

196

Better remove both QLatin1Char and just compare chars.

206

Same here, and more that follow

This revision now requires changes to proceed.Oct 1 2019, 9:50 AM
ahmadsamir updated this revision to Diff 67125.Oct 1 2019, 12:58 PM

Make it faster by comparing char's directly

dfaure accepted this revision.Oct 2 2019, 8:20 AM
This revision is now accepted and ready to land.Oct 2 2019, 8:20 AM
Closed by commit R241:3b98d91436f5: [DataProtocol] compile without implicit coversion from ascii (authored by ahmadsamir). · Explain WhyOct 4 2019, 3:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/dataprotocol.cpp (24 lines)

Diff 67062

View Options

src/core/dataprotocol.cpp

Loading...