Differential D24293

Make QSslError::SslError <-> KSslError::Error conversion reusable
ClosedPublic
Actions

Authored by vkrause on Sep 29 2019, 9:06 AM.

Details

Reviewers
dfaure
aacid
Commits
R241:fab04a62f2ca: Make QSslError::SslError <-> KSslError::Error conversion reusable
Summary

This will allow a step by step migration of the certificate manager and
kssld code to QSslError.

The conversion is lossy (QSslError can represent more details than
KSslError), but as long as the input is still a KSslError that is not
a problem.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Sep 29 2019, 9:06 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 29 2019, 9:06 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Sep 29 2019, 9:06 AM
aacid accepted this revision.Sep 29 2019, 9:43 AM
This revision is now accepted and ready to land.Sep 29 2019, 9:43 AM
Closed by commit R241:fab04a62f2ca: Make QSslError::SslError <-> KSslError::Error conversion reusable (authored by vkrause). · Explain WhySep 30 2019, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMsrc/core/ksslerror_p.h (35 lines)
Msrc/core/ktcpsocket.cpp (161 lines)

Diff 67077

View Options

src/core/ksslerror_p.h

Loading...
View Options

src/core/ktcpsocket.cpp

Loading...