The code compiles and tests pass
Details
Details
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- ahmad/foreach-filewidgets (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17136 Build 17154: arc lint + arc unit
Comment Actions
Cool, I'll review this. BTW don't touch begin/end loops, that's done in D24160 already.
src/filewidgets/kurlnavigator.cpp | ||
---|---|---|
803 | I thought button->deleteLater() may change m_navButtons, doesn't it? |
src/filewidgets/kurlnavigator.cpp | ||
---|---|---|
803 | How would it? It doesn't know that container. All it does is posting an event to that object. The container isn't modified. [and even a real C++ delete wouldn't modify the container itself, only the objects it points to] |
src/filewidgets/kfilepreviewgenerator.cpp | ||
---|---|---|
733–734 | keys() is what is slow (it creates and fills a temporary container) You want m_cutItemsCache.cbegin() |
Comment Actions
Don't iterate over the temp. container returned by qhash.keys(), rather over the qhash itself