[WIP] let one category be embedded in the ViewSelector
AbandonedPublic
Actions

Authored by mgallien on Sep 22 2019, 4:57 PM.

Details

Reviewers

Group Reviewers

Elisa

Summary

only possible for all albums, all artists and all genres

related to T11154

Test Plan

after adding
[Views]
EmbeddedView=3

Genres are added to ViewSelector list

navigation is not yet there

feedback on the visual would be much apprecited

Repository

R255 Elisa

Branch

dataInViewsList

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16930
Build 16948: arc lint + arc unit

mgallien requested review of this revision.Sep 22 2019, 4:57 PM

mgallien created this revision.

navigation for artists and genres is working

navigation for abums is not working

Super cool!

Moved to gitlab merge request

		Path
M		autotests/CMakeLists.txt (20 lines)
M		autotests/datamodeltest.cpp (18 lines)
A	M	autotests/viewsmodeltest.cpp (539 lines)
M		src/elisa_core.kcfg (10 lines)
M		src/elisaapplication.h (10 lines)
M		src/elisaapplication.cpp (25 lines)
M		src/models/datamodel.cpp (34 lines)
M		src/models/viewsmodel.h (59 lines)
M		src/models/viewsmodel.cpp (420 lines)
M		src/qml/ContentView.qml (10 lines)
M		src/qml/ViewSelector.qml (70 lines)
M		src/qml/ViewSelectorDelegate.qml (5 lines)
M		src/viewmanager.h (18 lines)
M		src/viewmanager.cpp (62 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66628	5e0c768		Sep 22 2019, 4:57 PM	★	★
Diff 2	66699	5e0c768	- partially implement navigation from the extra items in views list	Sep 23 2019, 7:39 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
038b4e72972a	f088c0635448	c31a251b690e	Matthieu Gallien	partially implement navigation from the extra items in views list	Sep 23 2019, 7:37 PM
c31a251b690e	219a6a6f0023	5e0c768598c1	Matthieu Gallien	[WIP] let one category be embedded in the ViewSelector (Show More…)	Sep 22 2019, 4:40 PM