They are not namespaced and promote the use of pixmaps rather than
icons. Additionally their API allowing to specify a size that differs
from the size suggested by their name leads to bizarre usage like
'SmallIcon("foo", KIconLoader::SizeLarge)'.
Details
Details
Diff Detail
Diff Detail
- Repository
- R302 KIconThemes
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
LOL I had no idea that one could do SmallIcon("foo", KIconLoader::SizeLarge) ;-)
I think 95% of the uses of these functions only specifies one argument.
Then again, I just grepped for usage of SmallIcons in KF5, and one of the only two hits in non-deprecated modules is....
kio/src/filewidgets/kimagefilepreview.cpp
200: imageLabel->setPixmap(SmallIcon(QStringLiteral("image-missing"), KIconLoader::SizeLarge,Can you port KIO?
Also I think you're missing #ifndef KICONTHEMES_NO_DEPRECATED around the newly deprecated methods
(which helps to do a local experimental build with this being set, to catch all users and port them).
Comment Actions
kio/src/widgets/ksslinfodialog.cpp also has 7 uses of BarIcon.
(and that's all I can find in all of KF5)
Comment Actions
Right, usage is fortunately not very wide-spread anymore. Before porting the remaining users I just wanted to be sure there are no objections to the general idea.