[GTK3] CSD windows show handles on .solid-csd
ClosedPublic

Authored by cblack on Sep 20 2019, 10:46 PM.

Details

Summary

CSD windows will now show 5px handles on windows with .solid-csd (CSD windows in window managers that do not support GTK frame extents)

BUG: 412080
FIXED-IN: 5.17.0

Test Plan

Handle before (KWin):

Handle after (KWin):

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Sep 20 2019, 10:46 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 20 2019, 10:46 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sep 20 2019, 10:46 PM
ndavis added a subscriber: ndavis.Sep 20 2019, 11:18 PM

What is that white dot in the corner?

cblack updated this revision to Diff 66568.Sep 20 2019, 11:24 PM

Remove superfluous border radius

cblack edited the test plan for this revision. (Show Details)Sep 20 2019, 11:25 PM
ngraham accepted this revision.Sep 20 2019, 11:27 PM
ngraham edited the summary of this revision. (Show Details)
ngraham added a subscriber: ngraham.

Sweet, this is a great usability fix.

This revision is now accepted and ready to land.Sep 20 2019, 11:27 PM

Actually now that I look closely I still see the transparent pixel in the corner from a transparent border radius:

cblack updated this revision to Diff 66571.Sep 21 2019, 1:05 AM

Add selectors for applications like gedit that do not have headerbar as direct child of window

Actually now that I look closely I still see the transparent pixel in the corner from a transparent border radius:

Above change should resolve it, try it out.

Looks fixed on my end

ndavis accepted this revision.Sep 21 2019, 1:17 AM
ngraham accepted this revision.Sep 21 2019, 1:35 AM

Yep, fixed in Gedit too now.

This revision was automatically updated to reflect the committed changes.
wbauer added a subscriber: wbauer.Wed, Oct 30, 10:10 AM

Could this be backported to 5.12 too maybe?

Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC.

Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC.

Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the gtk.css in the first place.

It should be possible to adjust that directly though, no?

Yeah, probably.

Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC.

Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the gtk.css in the first place.

It should be possible to adjust that directly though, no?

This wouldn't be too hard to backport the results by hand.

wbauer added a comment.EditedWed, Oct 30, 6:20 PM

FTR, we got a downstream bug report about this for openSUSE Leap 15.1 (which ships Plasma 5.12 LTS):
https://bugzilla.opensuse.org/show_bug.cgi?id=1155387

That's mainly why I asked... ;-)

But it certainly does look like a worthwhile fix for the current upstream LTS release anyway, IMHO.

This comment was removed by davidedmundson.