Fix crash when guiding unexpectedly restarting with no current job.
ClosedPublic

Authored by TallFurryMan on Fri, Sep 20, 7:31 AM.

Details

Summary

When Scheduler stops activity, and specifically stops guiding, guiding timer is still active and will crash KStars when elapsing.

Test Plan
  • Make Scheduler finish a job that is guiding, so that there is no current job.
  • Without the change, KStars crashes after the guider timeout elapses (hardcoded 5s).
  • With the change, Scheduler does not automatically restart guiding.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
TallFurryMan created this revision.Fri, Sep 20, 7:31 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFri, Sep 20, 7:31 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Fri, Sep 20, 7:31 AM
TallFurryMan edited the test plan for this revision. (Show Details)Sun, Sep 22, 8:02 PM
mutlaqja added inline comments.Mon, Sep 23, 5:09 AM
kstars/ekos/scheduler/scheduler.cpp
3869

This is not executed in many blocks above where it was removed.

TallFurryMan added inline comments.Mon, Sep 23, 5:52 AM
kstars/ekos/scheduler/scheduler.cpp
3869

Agreed, but it was systematically executed after stopCurrentJobAction. This is therefore some kind of refactoring.

mutlaqja accepted this revision.Mon, Sep 23, 8:04 AM
This revision is now accepted and ready to land.Mon, Sep 23, 8:04 AM
This revision was automatically updated to reflect the committed changes.