Differential D24107

Fix crash when guiding unexpectedly restarting with no current job.
ClosedPublic
Actions

Authored by TallFurryMan on Sep 20 2019, 7:31 AM.

Details

Reviewers
mutlaqja
wreissenberger
alexcherney
Commits
R321:96a57b6e6ee5: Fix crash when guiding unexpectedly restarting with no current job.
Summary

When Scheduler stops activity, and specifically stops guiding, guiding timer is still active and will crash KStars when elapsing.

Test Plan
  • Make Scheduler finish a job that is guiding, so that there is no current job.
  • Without the change, KStars crashes after the guider timeout elapses (hardcoded 5s).
  • With the change, Scheduler does not automatically restart guiding.

Diff Detail

Repository
R321 KStars
Branch
bugfix__crash_guiding (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16823
Build 16841: arc lint + arc unit
TallFurryMan created this revision.Sep 20 2019, 7:31 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 20 2019, 7:31 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
TallFurryMan requested review of this revision.Sep 20 2019, 7:31 AM
TallFurryMan edited the test plan for this revision. (Show Details)Sep 22 2019, 8:02 PM
TallFurryMan added reviewers: mutlaqja, wreissenberger, alexcherney.
mutlaqja added inline comments.Sep 23 2019, 5:09 AM
kstars/ekos/scheduler/scheduler.cpp
3869

This is not executed in many blocks above where it was removed.

TallFurryMan added inline comments.Sep 23 2019, 5:52 AM
kstars/ekos/scheduler/scheduler.cpp
3869

Agreed, but it was systematically executed after stopCurrentJobAction. This is therefore some kind of refactoring.

mutlaqja accepted this revision.Sep 23 2019, 8:04 AM
This revision is now accepted and ready to land.Sep 23 2019, 8:04 AM
Closed by commit R321:96a57b6e6ee5: Fix crash when guiding unexpectedly restarting with no current job. (authored by TallFurryMan, committed by mutlaqja). · Explain WhySep 23 2019, 8:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkstars/ekos/scheduler/scheduler.cpp (57 lines)

Diff 66525

View Options

kstars/ekos/scheduler/scheduler.cpp

Loading...