Differential D24033

Add Meta+Space as a default shortcut to activate KRunner
ClosedPublic
Actions

Authored by ngraham on Sep 17 2019, 7:17 PM.

Details

Reviewers
ndavis
GB_2
Group Reviewers
VDG
Plasma
Commits
R120:4000bd5db5f4: Add Meta+Space as a default shortcut to activate KRunner
Summary

There are two proposed justifications for this addition:

  • In general, VDG would like to move towards consistently using the Meta key for global shortcuts
  • Switching macOS users will be able to activate KRunner with the exact same keyboard shortcut they used to activate Spotlight

Diff Detail

Repository
R120 Plasma Workspace
Branch
meta-space-for-krunner (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16700
Build 16718: arc lint + arc unit
ngraham created this revision.Sep 17 2019, 7:17 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 17 2019, 7:17 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Sep 17 2019, 7:17 PM
ngraham edited the summary of this revision. (Show Details)Sep 17 2019, 7:19 PM
ndavis accepted this revision.Sep 17 2019, 7:26 PM
ndavis added a subscriber: ndavis.

+1, but I'm curious what others have to say. I definitely agree that Meta should be for global shortcuts and global desktop shell related shortcuts in particular.

This revision is now accepted and ready to land.Sep 17 2019, 7:26 PM
romangg added a subscriber: romangg.EditedSep 17 2019, 7:39 PM

I agree with Meta instead of Alt for all "system shortcuts". Hence I would like to see this as well for all window manager operations. Meta => system, Ctrl, Alt => applications.

EDIT: Alt+Tab for window switcher is the exception.

GB_2 added a subscriber: GB_2.Sep 17 2019, 7:43 PM
In D24033#533505, @romangg wrote:

I agree with Meta instead of Alt for all "system shortcuts". Hence I would like to see this as well for all window manager operations. Meta => system, Ctrl, Alt => applications.

EDIT: Alt+Tab for window switcher is the exception.

Relevant: https://bugs.kde.org/show_bug.cgi?id=399375

GB_2 accepted this revision as: GB_2.Sep 17 2019, 7:43 PM
ngraham added a comment.Sep 17 2019, 7:44 PM
In D24033#533505, @romangg wrote:

I agree with Meta instead of Alt for all "system shortcuts". Hence I would like to see this as well for all window manager operations. Meta => system, Ctrl, Alt => applications.

EDIT: Alt+Tab for window switcher is the exception.

Yeah, that's pretty much how I feel about it too.

Closed by commit R120:4000bd5db5f4: Add Meta+Space as a default shortcut to activate KRunner (authored by ngraham). · Explain WhySep 17 2019, 7:45 PM
This revision was automatically updated to reflect the committed changes.
alzoubi added a subscriber: alzoubi.Dec 22 2019, 4:58 PM

Meta+Space used for chang Keyboard Layout.

ngraham added a comment.Dec 22 2019, 6:19 PM

By ibus, yeah. :/ I found that out last week. I'm probably going to end up reverting this.

alam added a subscriber: alam.Jan 9 2020, 7:01 PM

Hi @ngraham

Have you got chance to revert it?

As KDE multilingual user, I still not able to use ibus keyboard in KDE from last month even tried to reset keyboard shortcut.

Help will be really appreciated.

ngraham added a comment.Jan 9 2020, 7:41 PM

Yes, I reverted it in 469a7c1e33f83d6b73610997811fb131b5af80ca, which was released with Plasma 5.17.5.

Revision Contents
Changeset List

PathPackages
Mkrunner/krunner.desktop.cmake (2 lines)

Diff 66327

View Options

krunner/krunner.desktop.cmake

Loading...