Differential D23955

KBookmark: improve addBookmark apidox
ClosedPublic
Actions

Authored by elvisangelaccio on Sep 15 2019, 10:16 AM.

Details

Reviewers
dfaure
Commits
R294:797763d4b4d2: KBookmark: improve addBookmark apidox
Summary

Clarify that the URL will be stored in its toString(QUrl::FullyEncoded)
version.

Diff Detail

Repository
R294 KBookmarks
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16568
Build 16586: arc lint + arc unit
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 15 2019, 10:16 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Sep 15 2019, 10:16 AM
dfaure accepted this revision.Sep 15 2019, 10:25 AM

OK (why does this matter to the user of the class, though?)

This revision is now accepted and ready to land.Sep 15 2019, 10:25 AM
elvisangelaccio added a comment.Sep 15 2019, 10:27 AM
In D23955#531647, @dfaure wrote:

OK (why does this matter to the user of the class, though?)

See D23706, dolphin is going to need regex-based matches on the placesmodel URLs.

Closed by commit R294:797763d4b4d2: KBookmark: improve addBookmark apidox (authored by elvisangelaccio). · Explain WhySep 15 2019, 6:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kbookmark.h (3 lines)

Diff 66108

View Options

src/kbookmark.h

Loading...