KBookmark: improve addBookmark apidox
ClosedPublic
Actions

Authored by elvisangelaccio on Sep 15 2019, 10:16 AM.

Details

Reviewers

dfaure

Commits

R294:797763d4b4d2: KBookmark: improve addBookmark apidox

Summary

Clarify that the URL will be stored in its toString(QUrl::FullyEncoded)
version.

Repository

R294 KBookmarks

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

OK (why does this matter to the user of the class, though?)

This revision is now accepted and ready to land.Sep 15 2019, 10:25 AM

In D23955#531647, @dfaure wrote:

OK (why does this matter to the user of the class, though?)

See D23706, dolphin is going to need regex-based matches on the placesmodel URLs.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kbookmark.h (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66108	7be24c6		Sep 15 2019, 10:16 AM	★	★
Diff 2	66148	7be24c6	R294:797763d4b4d2b7c91fb3814bf86374ccd7e0de1d	Sep 15 2019, 10:16 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
9f05deaf3916	976208fb3005	7be24c6d3232	Elvis Angelaccio	KBookmark: improve addBookmark apidox (Show More…)	Sep 15 2019, 10:13 AM