Remove panel toolbox
AbandonedPublic

Authored by GB_2 on Sep 15 2019, 8:46 AM.

Details

Summary

With D23951 we greatly improve the discoverability of the panel edit mode, so there isn't a need for a button in the panel anymore that just takes up space (especially since with D23951 we're basically always in unlocked mode) and we get asked about how to remove it from time to time.

Test Plan

Look at the panel.

Diff Detail

Repository
R119 Plasma Desktop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16916
Build 16934: arc lint + arc unit
GB_2 created this revision.Sep 15 2019, 8:46 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 15 2019, 8:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Sep 15 2019, 8:46 AM
GB_2 retitled this revision from Remove panel toolbox clean up editing options to Remove panel toolbox and clean up editing options.Sep 15 2019, 9:08 AM

Hmm, after applying and compiling all three patches and then restarting plasmashell, I still see the panel toolbox.

GB_2 added a comment.Sep 15 2019, 7:41 PM

Hmm, after applying and compiling all three patches and then restarting plasmashell, I still see the panel toolbox.

That's because you still have the files and manually compiling and installing won't delete them :-)
The package manager does that.

Oh, of course.

GB_2 updated this revision to Diff 66159.EditedSep 15 2019, 9:11 PM

Add back "Show Alternatives..." item and remove reference to panel toolbox

GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 9:12 PM
GB_2 edited the summary of this revision. (Show Details)
GB_2 edited the summary of this revision. (Show Details)Sep 15 2019, 9:31 PM
GB_2 edited the summary of this revision. (Show Details)
GB_2 edited the test plan for this revision. (Show Details)
mart requested changes to this revision.Sep 16 2019, 11:04 AM
mart added a subscriber: mart.

i'm in general not in favor of having only right click.
this patch will be fine, only after the global edit mode button will be in systemsettings.
That is an absolute blocker for me

This revision now requires changes to proceed.Sep 16 2019, 11:04 AM
mart added a comment.Sep 16 2019, 11:14 AM

moreover, as i plan to do with the desktop one, it should still be there, just not shown in non-edit mode

I agree that we can't only have this UI be in a context menu, and we need to expose it somewhere visible too (i.e. in System Settings like we discussed at the Plasma + Usability & Productivity sprint.

I kind of like not showing the configure button in the panel though. It bugs the heck out of me and break's Fitts' law for the screen corner pixel that it appears next to, which is particularly unfortunate as we now do ship a widget that benefits from being activated by a screen corner pixel (Show Desktop).

GB_2 planned changes to this revision.Sep 22 2019, 7:42 PM

I agree that we can't only have this UI be in a context menu, and we need to expose it somewhere visible too (i.e. in System Settings like we discussed at the Plasma + Usability & Productivity sprint.

I kind of like not showing the configure button in the panel though. It bugs the heck out of me and break's Fitts' law for the screen corner pixel that it appears next to, which is particularly unfortunate as we now do ship a widget that benefits from being activated by a screen corner pixel (Show Desktop).

Ok, let's wait with removing the panel toolbox then until we expose it somewhere else.

GB_2 retitled this revision from Remove panel toolbox and clean up editing options to Remove panel toolbox.Sep 23 2019, 3:42 PM
GB_2 edited the summary of this revision. (Show Details)
GB_2 updated this revision to Diff 66671.Sep 23 2019, 3:46 PM

Remove unrelated change

GB_2 planned changes to this revision.Sep 23 2019, 3:46 PM
GB_2 edited the test plan for this revision. (Show Details)
GB_2 abandoned this revision.Sep 28 2019, 8:30 AM