Differential D23917

Use const_iterator
ClosedPublic
Actions

Authored by gladhorn on Sep 12 2019, 8:07 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R127:28841048d555: Use const_iterator
Summary

When trivial, replace iterators with the const version.

Diff Detail

Repository
R127 KWayland
Branch
master
Lint
Lint ErrorsExcuse: ignore this
SeverityLocationCodeMessage
Errorsrc/client/keystate.h:50CppcheckunknownMacro
Unit
No Unit Test Coverage
Build Status
Buildable 16501
Build 16519: arc lint + arc unit
gladhorn created this revision.Sep 12 2019, 8:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 12 2019, 8:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
gladhorn requested review of this revision.Sep 12 2019, 8:07 PM
zzag added a subscriber: zzag.Sep 12 2019, 8:10 PM
zzag added inline comments.
src/server/output_interface.cpp
119 ↗(On Diff #65946)

constEnd

zzag added inline comments.Sep 12 2019, 8:12 PM
src/client/registry.cpp
879 ↗(On Diff #65946)

constEnd

broulik added a subscriber: broulik.Sep 12 2019, 8:33 PM

If the container is const already there's no real reason to explicitly use constBegin which is effectively the same

zzag added a comment.Sep 12 2019, 8:45 PM
In D23917#530297, @broulik wrote:

If the container is const already there's no real reason to explicitly use constBegin which is effectively the same

Yes, however it's still a good idea to be explicit about it.

gladhorn added a comment.Sep 14 2019, 8:28 AM

Yes, for me always using constBegin/constEnd makes reading the code slightly easier.

src/client/registry.cpp
879 ↗(On Diff #65946)

Thanks!

src/server/output_interface.cpp
119 ↗(On Diff #65946)

Thanks!

gladhorn updated this revision to Diff 66021.Sep 14 2019, 8:29 AM
gladhorn edited the summary of this revision. (Show Details)
gladhorn removed subscribers: broulik, zzag.

Fixed two missing spots

zzag accepted this revision.Sep 14 2019, 8:44 AM
This revision is now accepted and ready to land.Sep 14 2019, 8:44 AM
Closed by commit R127:28841048d555: Use const_iterator (authored by gladhorn). · Explain WhySep 14 2019, 9:09 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 5 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/client/registry.cpp (10 lines)
Msrc/server/output_interface.cpp (12 lines)

Diff 66021

View Options

src/client/registry.cpp

Loading...
View Options

src/server/output_interface.cpp

Loading...