Port SearchLineWidget to use KBusyIndicatorWidget
AbandonedPublic

Authored by broulik on Sep 12 2019, 4:24 PM.

Details

Reviewers
aacid
Group Reviewers
Okular
Summary

It's a lot nicer than manually painting a KPixmapSequence and supports high dpi out of the box.

Test Plan

T11637
It is pretty new, so maybe too new for the frameworks dep of KDE Applications / Okular

  • Busy indicator is prety now

Diff Detail

Repository
R223 Okular
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Sep 12 2019, 4:24 PM
Restricted Application added a project: Okular. · View Herald TranscriptSep 12 2019, 4:24 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
broulik requested review of this revision.Sep 12 2019, 4:24 PM
sitter added a subscriber: sitter.Sep 12 2019, 4:27 PM

It's marvelous!

sander added a subscriber: sander.Sep 12 2019, 6:27 PM

The code looks promising, but I cannot test it because that kbusyindicatorwidget.h is so new it's not in my Debian yet. I am not sure we want to unconditionally depend on something so new.

aacid added a comment.Sep 13 2019, 6:53 AM

Please use invent.

The CI there will tell you if the change is acceptable regarding dependency versions