Port from KIconLoader to QIcon::fromTheme
ClosedPublic

Authored by vkrause on Sep 12 2019, 12:52 PM.

Diff Detail

Repository
R311 KWallet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Sep 12 2019, 12:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 12 2019, 12:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Sep 12 2019, 12:52 PM
dfaure requested changes to this revision.Sep 12 2019, 12:58 PM
dfaure added inline comments.
src/runtime/kwalletd/kwalletd.cpp
636

The 64 seems a bit too hardcoded, and KPasswordDialog internally defaults to q->style()->pixelMetric(QStyle::PM_MessageBoxIconSize, &option, q) (when setPixmap isn't called).

I think the first step is to add a setIcon to KPasswordDialog.

src/runtime/kwalletd/kwalletwizard.cpp
52

(we should add a setIcon overload to KTitleWidget, this setPixmap method is misnamed).

This revision now requires changes to proceed.Sep 12 2019, 12:58 PM

Yep, makes sense.

vkrause updated this revision to Diff 65920.Sep 12 2019, 1:48 PM

Make use of D23904.

dfaure accepted this revision.Sep 13 2019, 8:43 AM

Beautiful :-)

This revision is now accepted and ready to land.Sep 13 2019, 8:43 AM
vkrause updated this revision to Diff 65985.Sep 13 2019, 1:02 PM

Adapt to widgetaddons changes.
When can this land considering it depends on brand new API in another framework?

You can land it as soon as the underlying API changes are in. KF5 is treated like a single repo in terms of inter-framework dependencies.

dfaure accepted this revision.Sep 13 2019, 1:05 PM
This revision was automatically updated to reflect the committed changes.