Details
Details
- Reviewers
davidedmundson dfaure - Maniphest Tasks
- T11637: KIconThemes Cleanups
- Commits
- R311:ef7ec39e9be1: Port from KIconLoader to QIcon::fromTheme
Diff Detail
Diff Detail
- Repository
- R311 KWallet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/runtime/kwalletd/kwalletd.cpp | ||
---|---|---|
636 | The 64 seems a bit too hardcoded, and KPasswordDialog internally defaults to q->style()->pixelMetric(QStyle::PM_MessageBoxIconSize, &option, q) (when setPixmap isn't called). I think the first step is to add a setIcon to KPasswordDialog. | |
src/runtime/kwalletd/kwalletwizard.cpp | ||
52 | (we should add a setIcon overload to KTitleWidget, this setPixmap method is misnamed). |
Comment Actions
Adapt to widgetaddons changes.
When can this land considering it depends on brand new API in another framework?
Comment Actions
You can land it as soon as the underlying API changes are in. KF5 is treated like a single repo in terms of inter-framework dependencies.