Differential D23894

[KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()
ClosedPublic
Actions

Authored by dfaure on Sep 12 2019, 10:18 AM.

Details

Reviewers
mart
davidedmundson
Maniphest Tasks
T11553: Port KDE Frameworks away from deprecated methods in Qt
Commits
R296:d8915db6c5fe: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()
Summary

I'm assuming we don't want to rename the property just yet, for SC?
Are the TODO KF6 correct?

Test Plan

Builds

Diff Detail

Repository
R296 KDeclarative
Branch
qwheelevent
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16476
Build 16494: arc lint + arc unit
dfaure created this revision.Sep 12 2019, 10:18 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 12 2019, 10:18 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Sep 12 2019, 10:18 AM
aacid added a subscriber: aacid.Sep 13 2019, 9:36 AM

maybe add the angleX property so we can tell people to move from angle to angleX and in KF6 we can remove angle and all is nice?

dfaure updated this revision to Diff 65984.Sep 13 2019, 12:58 PM

Add deltaY property (good idea).

Not that QML code will get any warning for using a deprecated property though...

aacid added a comment.Sep 13 2019, 5:31 PM
In D23894#530619, @dfaure wrote:

Not that QML code will get any warning for using a deprecated property though...

Maybe something we can suggest for KF6 to add a DEPRECATED to properties?

Anyhow this looks good to me, not a very kdeclartive knowledgeable person so maybe wait for the others to accept :)

davidedmundson accepted this revision.Sep 14 2019, 6:23 AM

Kf6 ideally we drop this whole class and the new event handlers will do everything properly without these hacks...let's see.

This revision is now accepted and ready to land.Sep 14 2019, 6:23 AM
dfaure closed this revision.Sep 14 2019, 10:15 AM

Revision Contents
Changeset List

Diff 65984

View Options

src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h

Loading...
View Options

src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp

Loading...