Restrict pausing to image capturing
AcceptedPublic

Authored by wreissenberger on Mon, Sep 9, 8:21 PM.

Details

Summary

The capturing process can currently be paused at arbitrary stages, not only during capturing. This behavior cannot be covered by the current state model of the Capture module. But fixing this needs significant refactoring.

As an intermediate solution, a warning is issued when the "Pause" button is pressed but no capture is running. If the Capture module is not in the capturing mode, pressing the pause button is ignored.

Test Plan

Test pressing the pause button during a meridian flip or the post flip alignment. Without this fix, the Capture module gives the impression, that a pause is planned. But after completing the re-alignment after a meridian flip, capturing continues. With this fix, pausing is not possible until the Capture module is capturing frames.

Diff Detail

Repository
R321 KStars
Branch
bug_pause_during_mf
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16286
Build 16304: arc lint + arc unit
wreissenberger created this revision.Mon, Sep 9, 8:21 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMon, Sep 9, 8:21 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Mon, Sep 9, 8:21 PM
wreissenberger edited the test plan for this revision. (Show Details)Mon, Sep 9, 8:21 PM
mutlaqja accepted this revision.Mon, Sep 9, 8:26 PM
This revision is now accepted and ready to land.Mon, Sep 9, 8:26 PM