- cmake
- prints warning
- can be overridden with CMAKE_DISABLE_FIND_PACKAGE_foo
Details
- Reviewers
davidedmundson - Group Reviewers
Plasma - Commits
- R135:f1191def10a0: use the feature summary to communicate runtime deps
Diff Detail
- Repository
- R135 Integration for Qt applications in Plasma
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I like packages stating their dependencies (even runtime ones) because that's where I look first as a packager. But if I'm not missing something (maybe a git add?) this change is a bit misleading because they can never be found. So I think two Find... modules are also needed or "message..." should stay.
Well, I understand that but I *really* don't think a message should be shown, that always yields the same result, no matter if it can be disabled via CMAKE_D_F_P_Foo or the packages in question are installed or not. What's the difference to message in that case?
Also imagine a user investigating why the two packages don't show up although he has installed them.
In the landing version I have added notes about them not being detected automatically and how to ignore them. That said, if you want to write a reliable font finder that would be pretty cool.