Differential D23688

Allow to customize attributes for KSyntaxHighligting themes
ClosedPublic
Actions

Authored by nibags on Sep 3 2019, 5:49 AM.

Details

Reviewers
dhaumann
cullmann
Group Reviewers
KTextEditor
Commits
R39:1c0b0069b960: Allow to customize attributes for KSyntaxHighligting themes
Summary

The diff D23516 introduce a regression: it isn't possible to customize the bold, italic, underline and strikeout attributes from the settings (Settings > Configure Kate... > Fonts & Colors > Default Text Styles), for KSyntaxHighligting themes.

By using format.isValid(), the attributes of the KSyntaxHighligting theme are being overwritten to the theme already applied by KTextEditor and to the theme customizations by the user.

The format.isValid() verification is removed, only the attributes set in the syntax definition files are applied.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nibags created this revision.Sep 3 2019, 5:49 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 3 2019, 5:49 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags requested review of this revision.Sep 3 2019, 5:49 AM
nibags retitled this revision from Allow customizing theme attributes in KSyntaxHighligting themes to Allow to customize attributes for KSyntaxHighligting themes.Sep 3 2019, 5:52 AM
cullmann accepted this revision.Sep 3 2019, 6:59 AM

Ok, thanks for the fix!

This revision is now accepted and ready to land.Sep 3 2019, 6:59 AM
Closed by commit R39:1c0b0069b960: Allow to customize attributes for KSyntaxHighligting themes (authored by nibags, committed by cullmann). · Explain WhySep 3 2019, 4:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/syntax/katehighlight.cpp (18 lines)

Diff 65340

View Options

src/syntax/katehighlight.cpp

Loading...