Allow to customize attributes for KSyntaxHighligting themes

Authored by nibags on Sep 3 2019, 4:43 PM.

Description

Allow to customize attributes for KSyntaxHighligting themes

Summary:
The diff D23516 introduce a regression: it isn't possible to customize the bold, italic, underline and strikeout attributes from the settings (Settings > Configure Kate... > Fonts & Colors > Default Text Styles), for KSyntaxHighligting themes.

By using format.isValid(), the attributes of the KSyntaxHighligting theme are being overwritten to the theme already applied by KTextEditor and to the theme customizations by the user.

The format.isValid() verification is removed, only the attributes set in the syntax definition files are applied.

Reviewers: KTextEditor, dhaumann, cullmann

Reviewed By: KTextEditor, cullmann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: Kate, Frameworks

Differential Revision: https://phabricator.kde.org/D23688