Make use of KPluginMetaData where we can
Needs ReviewPublic

Authored by apol on Mon, Sep 2, 5:11 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Instead of relying on the older KPluginInfo which is slower (parses de metadata twice) and comes from a much higher tier.

Test Plan

Running plasmashell with it

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16060
Build 16078: arc lint + arc unit
apol created this revision.Mon, Sep 2, 5:11 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMon, Sep 2, 5:11 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Mon, Sep 2, 5:11 PM
broulik added a subscriber: broulik.Mon, Sep 2, 6:09 PM
broulik added inline comments.
src/plasma/containmentactions.h
70–79
@deprecated since 5.62 use metadata
src/plasma/dataengine.cpp
70

Where is this constructor used?

src/plasma/dataengine.h
80

Docs, with @since

120

5

src/plasma/scripting/dataenginescript.cpp
91–96

Does this need a KPluginMetadata getter?

src/plasma/theme.cpp
444

Does this need a separate metadata() getter?

src/plasma/theme.h
321–330

Separate @deprecated since line

apol updated this revision to Diff 65327.Tue, Sep 3, 2:31 PM

address comments

apol updated this revision to Diff 65328.Tue, Sep 3, 2:37 PM
apol marked 6 inline comments as done.

Forgot these