Differential D23670

[KPropertiesDialog] Always check mount point being null
ClosedPublic
Actions

Authored by broulik on Sep 2 2019, 10:41 AM.

Details

Reviewers
dfaure
shubham
Group Reviewers
Frameworks
Commits
R241:3b571aacf7e9: [KPropertiesDialog] Always check mount point being null
Summary

File system type got added after the fact and outside the guard.

BUG: 411517

Test Plan
  • Set mp to null, didn't crash anymore

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 2 2019, 10:41 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 2 2019, 10:41 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Sep 2 2019, 10:41 AM
broulik edited the summary of this revision. (Show Details)Sep 2 2019, 11:41 AM
PureTryOut added a subscriber: PureTryOut.Sep 2 2019, 2:34 PM

I tested this patch as a fix for https://bugs.kde.org/show_bug.cgi?id=411517 and it did the trick, it doesn't crash anymore.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 2 2019, 2:36 PM
Closed by commit R241:3b571aacf7e9: [KPropertiesDialog] Always check mount point being null (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/kpropertiesdialog.cpp (14 lines)

Diff 65254

View Options

src/widgets/kpropertiesdialog.cpp

Loading...