Create and install CMake Config file for marble & astro libraries
ClosedPublic
Actions

Authored by kossebau on Aug 7 2016, 5:08 AM.

Details

Reviewers

sanjibanb
nienhueser
rahn
shentey

Group Reviewers

Marble

Commits

R34:b40c2cba738d: Create and install CMake Config file for marble & astro libraries

Summary

use "Marble" and "Astro" as cmake target names, so 3rd-party lib users would do: find_package(Marble REQUIRED) find_package(Astro REQUIRED) target_link_libraries(foo Marble Astro) # include dirs imported by target
only install headers & cmake config files on unbundled platforms for now

Diff Detail

Repository

R34 Marble

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau updated this revision to Diff 5709.Aug 7 2016, 5:08 AM

kossebau retitled this revision from to Create and install CMake Config file for marble & astro libraries.

kossebau updated this object.

kossebau added reviewers: Marble, rahn, sanjibanb, nienhueser, shentey.

Lovely, that is much needed. Great work! I guess tools/version/update-version-number.py needs a minor tweak also to deal with variable name changes like GENERIC_LIB_VERSION => MARBLE_LIB_VERSION.

src/lib/marble/CMakeLists.txt
433	Reminds me we need to get rid of that flag.

This revision is now accepted and ready to land.Aug 7 2016, 7:07 AM

Closed by commit R34:b40c2cba738d: Create and install CMake Config file for marble & astro libraries (authored by kossebau). · Explain WhyAug 7 2016, 1:02 PM

This revision was automatically updated to reflect the committed changes.

In D2364#44137, @nienhueser wrote:

Lovely, that is much needed. Great work! I guess tools/version/update-version-number.py needs a minor tweak also to deal with variable name changes like GENERIC_LIB_VERSION => MARBLE_LIB_VERSION.

I see. Changed the commit to also tweak that.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (4 lines)
A	M	src/lib/astro/AstroConfig.cmake.in (3 lines)
M		src/lib/astro/CMakeLists.txt (61 lines)
M		src/lib/marble/CMakeLists.txt (66 lines)
A	M	src/lib/marble/MarbleConfig.cmake.in (21 lines)
M		tools/version/update-version-number.py (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5709	9cf5076		Aug 7 2016, 5:08 AM	★	★
Diff 2	5714	79d2576	rMARBLEb40c2cba738dc1a659440587939791b7ffcbb138	Aug 7 2016, 1:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
c9aacdfdb3fa	0fda8bc3d240	9cf50760efce	Friedrich W. H. Kossebau	Create and install CMake Config file for marble & astro libraries (Show More…)	Aug 7 2016, 5:07 AM