gcc naming conflict

Authored by mickaelbo on Aug 27 2019, 10:31 AM.



With gcc 7.4.0 (and maybe some other versions), "major" and "minor" are set as macro and expand to "gnu_dev_major" and "gnu_dev_minor".
See: https://bugzilla.redhat.com/show_bug.cgi?id=130601

These strings are used in the affected file for variable naming.
The attached patch undef the gcc renaming.

A syntax-highlighting user, Jonathan, reported the issue, provided the patch and tested it after trying to compile the project when the last commit was authored by me. Thank you Jonathan.

Test Plan

The compilation shall not fail with gcc 7.4.0.

Diff Detail

R216 Syntax Highlighting
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
mickaelbo created this revision.Aug 27 2019, 10:31 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 27 2019, 10:31 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mickaelbo requested review of this revision.Aug 27 2019, 10:31 AM
cullmann requested changes to this revision.Aug 27 2019, 10:33 AM
cullmann added a subscriber: cullmann.

I would prefer that we just rename the vars.

This revision now requires changes to proceed.Aug 27 2019, 10:33 AM
mickaelbo updated this revision to Diff 64727.Aug 27 2019, 11:13 AM

It makes sense.

cullmann accepted this revision.Aug 27 2019, 11:14 AM

ok, thanks

This revision is now accepted and ready to land.Aug 27 2019, 11:14 AM
This revision was automatically updated to reflect the committed changes.